-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added a setting to always open folders in a new tab #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@oleitao To prevent these kinds of merge conflicts in the future, a good trick is to revert changes to all the resource files (with the exception of the en-US resource file). Doing this will make it much easier to resolve conflicts since you only need to fix one file. |
@oleitao can you solve the merge conflicts? |
@yaichenbaum I can, but i don't have access to do that |
@oleitao Do you have the GitHub desktop app? It's fairly simple to solve the conflicts using the UI when you merge the |
@oleitao in Files repo, open cmd:
After executing these commands, open VS and resolve conflicts by following VS' instructions |
# Conflicts: # Files/Interacts/Interaction.cs # Files/Strings/ar/Resources.resw # Files/Strings/da-DK/Resources.resw # Files/Strings/da/Resources.resw # Files/Strings/de-DE/Resources.resw # Files/Strings/es-ES/Resources.resw # Files/Strings/fr-FR/Resources.resw # Files/Strings/hi-IN/Resources.resw # Files/Strings/hu-HU/Resources.resw # Files/Strings/it-IT/Resources.resw # Files/Strings/ja-JP/Resources.resw # Files/Strings/ko-KR/Resources.resw # Files/Strings/nl-NL/Resources.resw # Files/Strings/or-IN/Resources.resw # Files/Strings/pl-PL/Resources.resw # Files/Strings/ru-RU/Resources.resw # Files/Strings/sv-SE/Resources.resw # Files/Strings/ta/Resources.resw # Files/Strings/tr-TR/Resources.resw # Files/Strings/uk-UA/Resources.resw # Files/Strings/zh-Hans/Resources.resw # Files/Strings/zh-Hant/Resources.resw # Files/ViewModels/SettingsViewModels/PreferencesViewModel.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleitao You seem to have not created the OpenFoldersNewTab property in PreferencesViewModel.cs
, just the field, so the bindings on the toggle switch aren't working.
You need to add something like this:
public bool OpenFoldersNewTab
{
get => openFoldersNewTab;
set
{
if (SetProperty(ref openFoldersNewTab, value))
{
App.AppSettings.OpenFoldersNewTab = value;
}
}
}
@oleitao It looks like opening folders when in grid or tiles view still opens them in the same tab, even though open folders in new tab is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
Details of Changes
Add details of changes here.
Closes #2129
Screenshots (optional)
