Skip to content

Conversation

winston-de
Copy link
Contributor

Resolved / Related Issues
Itemize resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Encode images as pngs before saving them as png files

Validation
How did you test these changes?

  • Built and ran the app (I wasn't able to reproduce the issue in the first place, so I can't be certain that it's fixed)
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested a review from tsvietOK April 18, 2021 21:00
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Apr 18, 2021
@d2dyno1
Copy link
Member

d2dyno1 commented Apr 19, 2021

@winston-de Just tested it. I've pasted an image on your build that'd be otherwise corrupted on the release store build. Looks like this PR fixes the issue. Good job!

@winston-de
Copy link
Contributor Author

@d2dyno1 Glad to hear it!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 19, 2021
@yaira2 yaira2 merged commit cae3ace into files-community:main Apr 19, 2021
@winston-de winston-de deleted the PasteImagesIntoDirectoryFix branch April 19, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pasting images from clipboard is not 100% reliable

3 participants