Auto refresh network folders on change #4999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix recycle bin update when restoring/clearing items
Only get one item
gave92
force-pushed
the
update_network_fix_bin
branch
from
6a03ba6 to
a1e8496
Compare
lukeblevins
suggested changes
May 23, 2021
There was a problem hiding this comment.
These changes are fine, but I think it would be better if we leveraged the reletiavely new TryGetChangeTracker method on StorageFolder.
It would provide more rich change descriptions and also works on any StorageFolder as of 1803.
This works a bit differently since we aren't subscribing to an event, but saves us from having to get a query result. Here's a sample authored from a Microsoft engineer: https://gist.github.com/jonwis/c61db33cc66016e6487e93acae356de3. We could use this minus the unnecessary FutureAccessList part.
lukeblevins
approved these changes
May 23, 2021
yaira2
added
the
ready to merge
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Add details of changes here.
Done using the "old" method of watching for folder changes (code taken from 0.9.2) only in case of network folders
Note: triggers a full refresh of the folder on any change <- @duke7553 there's no way to get what's changed is there?
Validation
How did you test these changes?