Added ability to close and open sidebar by resizing it

[winston-de]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Ability to close sidebar by dragging #4981

Details of Changes
Add details of changes here.

• Added ability to close and open sidebar by resizing it
• Added constant for minimum sidebar size
• Added visual effects for drag and hover over sidebar resizer
• Fixed only being able to drag sidebar by border

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

2021-05-23-185548.mp4

[yaira2]

@winston-de Is the resize janky on your end?

[winston-de]

Yeah a bit, I thought it may have just been my computer. I'll try and improve it.

[mdtauk]

Not sure how possible it is, but it feels like the sidebar resizing should snap to the closed state, when dragged below a minimum width.

If there is also a maximum width, the same should probably apply after the threshold is reached, when resizing outward.

[winston-de]

Not sure how possible it is, but it feels like the sidebar resizing should snap to the closed state, when dragged below a minimum width.

That's what it does now, unless I'm misunderstanding what you're saying.

If there is also a maximum width, the same should probably apply after the threshold is reached, when resizing outward.

I don't quite understand what you mean by this....

[winston-de]

@yaichenbaum It looks like the jankiness was already there before this PR. I think it's caused by binding directly to the SidebarWidth app setting directly and updating it on manipulation delta, leading to a lot of calls to get and set app settings. I'm working on improving it though.

[yaira2]

@yaichenbaum It looks like the jankiness was already there before this PR. I think it's caused by binding directly to the SidebarWidth app setting directly and updating it on manipulation delta, leading to a lot of calls to get and set app settings. I'm working on improving it though.

Interesting, it must have been introduced with all the recent refactoring around the sidebar, I'm glad we found it now!

[yaira2]

@winston-de are you still working on this?

[winston-de]

@winston-de are you still working on this?

Yes, I'll have it done in a bit.

[winston-de]

Alright I think I fixed the jankiness.

[yaira2]

@winston-de Can you resolve the merge conflicts and test these changes with the keyboard?