Skip to content

Improved the adaptive layout behavior #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 8, 2021
Merged

Improved the adaptive layout behavior #5140

merged 6 commits into from
Jun 8, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jun 5, 2021

Resolved / Related Issues

Details of Changes
This PR improves Adaptive Layout logic to decide better layout modes for directories. Feedback on the new logic is welcome!

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from winston-de June 6, 2021 02:05
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jun 6, 2021
lukeblevins
lukeblevins suggested changes Jun 6, 2021
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: You should be able to group variables of the same type into a single-line declaration.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Jun 6, 2021

Minor nit: You should be able to group variables of the same type into a single-line declaration.

Thanks, I'm aware of that I just prefer to declare them on separate lines so it's more readable :)

@lukeblevins lukeblevins self-requested a review June 6, 2021 15:57
lukeblevins
lukeblevins reviewed Jun 6, 2021
View reviewed changes
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed ready for review Pull requests that are ready for review labels Jun 7, 2021
yaira2
yaira2 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jun 8, 2021
@yaira2 yaira2 changed the title Improved Adaptive Layout Improved the adaptive layout behavior Jun 8, 2021
@yaira2
Copy link
Member

yaira2 commented Jun 8, 2021

@d2dyno1 can you take a look at the code factor issues?

@d2dyno1
Copy link
Member Author

d2dyno1 commented Jun 8, 2021

@d2dyno1 can you take a look at the code factor issues?

It looks like they weren't caused by this PR. Only one line was changed in said class (FolderSettingsViewModel). It seems like CodeFactor picked up on them since I changed the file.

@yaira2 yaira2 merged commit 550d681 into files-community:main Jun 8, 2021
@yaira2 yaira2 mentioned this pull request Jun 8, 2021
Closed
@d2dyno1 d2dyno1 deleted the imp_al branch June 8, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

@winston-de winston-de Awaiting requested review from winston-de

+1 more reviewer

@lukeblevins lukeblevins lukeblevins requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improving the logic for auto changing the layout mode

3 participants

@d2dyno1 @yaira2 @lukeblevins