-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added a dialog for extracting archives #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Try the library SevenZip to compare. |
If the slowness is due to storagefile operations I guess we could either:
|
Wow, thanks a lot @gave92! I settled on the first option but used only a hFile handle to create a |
@gave92 this is what we originally did, but we decided to remove the feature until we were able to implement a proper version. |
@yaichenbaum This PR has "the proper" version. Also, could you suggest some design ideas regarding the dialog? |
@d2dyno1 This is a quick mockup for the locations of the different options. |
@yaichenbaum What does this option do? |
It will open the folder with the extracted items. |
@d2dyno1 , I remembered one thing: there are cases that the zip file can contain a password. Currently, Windows File Explorer does not detect this, but this feature in the zip file decompressor would be interesting, if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Details of Changes
This PR adds decompressing feature with progress report and ability to cancel the operation. The performance is comparable to winrar.
Validation
How did you test these changes?