Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jun 29, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Use shell for file operations
  • Refactor fulltrust process

Pros of shell operations:

  • Progress for copying big files
  • Possibility to cancel ongoing operations
  • Reliability
  • Continue when closing the app

Implemented [updating]

  • Delete, Copy, Move, Rename, Restore from bin
  • Undo/Redo support
  • Cancel operations

TODO [updating]

  • Operations as admin
  • Test with drag&drop
  • Test on network drives, phone..

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review July 4, 2021 00:01
@gave92 gave92 added the ready for review Pull requests that are ready for review label Jul 4, 2021
@yaira2 yaira2 requested review from winston-de and yaira2 and removed request for winston-de July 4, 2021 02:32
@yaira2
Copy link
Member

yaira2 commented Jul 4, 2021

@gave92 Can you check what happens when you paste multiple items in the same directory you copied them from? It doesn't seem to do anything on my end.

@gave92
Copy link
Member Author

gave92 commented Jul 4, 2021

@gave92 Can you check what happens when you paste multiple items in the same directory you copied them from? It doesn't seem to do anything on my end.

I get the usual "conflicts resolution" dialog and if I choose "generate new name" the files get copied.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!! Thank you!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 4, 2021
@yaira2 yaira2 merged commit dd12008 into main Jul 4, 2021
@yaira2 yaira2 deleted the ShellOps branch July 4, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

3 participants