Skip to content

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jul 9, 2021

Resolved / Related Issues

Details of Changes

  • Readme files are now selected when entering a directory. Additionally, replaced INotifyPropertyChanged interface in ItemViewModel with toolkit's ObservableObject

Validation

  • Built and ran the app

@d2dyno1 d2dyno1 changed the title Select readme files in directory Preview readme files in directory Jul 10, 2021
@yaira2 yaira2 requested a review from winston-de July 11, 2021 02:17
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 11, 2021
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 11, 2021
@yaira2 yaira2 changed the title Preview readme files in directory Automatically preview readme files when no file is selected Jul 11, 2021
@yaira2 yaira2 merged commit 9e4211f into files-community:main Jul 11, 2021
@d2dyno1 d2dyno1 deleted the prvw_md branch July 11, 2021 21:21
@yaira2
Copy link
Member

yaira2 commented Aug 22, 2021

@d2dyno1 can you adjust the behavior so readme files are only selected when the preview pane is open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically preview readme files when no file is selected

3 participants