Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 8, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Changes

  • Fixes drag&drop from 7zip in release mode

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title [TEST] Fix drag&drop from 7zip in release mode Fix drag&drop from 7zip in release mode Oct 8, 2021
@gave92 gave92 marked this pull request as ready for review October 8, 2021 18:31
@gave92 gave92 requested a review from winston-de October 8, 2021 18:31
@gave92
Copy link
Member Author

gave92 commented Oct 8, 2021

@winston-de if you can verify if the issue is fixed for you as well it would be great. As for the changes I can't really explain why they're needed but who knows the mysteries of Release mode.

@gave92 gave92 added the ready for review Pull requests that are ready for review label Oct 8, 2021
Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works for me now, lgtm

@winston-de winston-de added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 8, 2021
@yaira2 yaira2 changed the title Fix drag&drop from 7zip in release mode Fixed drag and drop from 7zip Oct 8, 2021
@yaira2 yaira2 merged commit ea9c88b into files-community:main Oct 8, 2021
@gave92 gave92 deleted the issue_6302 branch October 9, 2021 08:31
@gave92 gave92 mentioned this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot Drag and Drop from 7zip

3 participants