Skip to content

Conversation

TomaszSteblik
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • Added a keyboard accelerator in MediaPreview user control that plays media on "ctrl+alt+p " as suggested.

Validation

  • Built and ran the app.

@yaira2 yaira2 requested a review from winston-de November 3, 2021 14:50
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 3, 2021
@winston-de
Copy link
Contributor

Would it be possible to change this to toggle instead of always playing? This way the media could be paused with the same hotkey used to play.

@TomaszSteblik
Copy link
Contributor Author

TomaszSteblik commented Nov 3, 2021

Sure, it is done. I have put function for that in code-behind because I felt like it is more of a view responsibility. If you would like me to change it to a command and put in a view-model just let me know.

Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@winston-de winston-de added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 4, 2021
@yaira2
Copy link
Member

yaira2 commented Nov 4, 2021

@TomaszSteblik great work! Can you add this new shortcut to the documentation site?

@yaira2 yaira2 changed the title Added a hotkey for playing audio and video from preview panel. Added a hotkey for playing audio and video in the preview pane Nov 4, 2021
@yaira2 yaira2 merged commit 005cdae into files-community:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Play back audio files in the preview pane via a hotkey

3 participants