-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added a toolbar button to empty recycle bin #6693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I added a couple comments on things I think should be adjusted.
@yaichenbaum I applied the changes except showing the New button. I don't think showing it is a good idea. What does the community think? |
I think it's best to avoid shifting the toolbar buttons. |
@yaichenbaum What are we doing concretely? |
I think it's best to add the icons to the right of the toolbar for now and to add back the "new" button. |
@yaichenbaum Ok for me. I would do that tomorrow. |
@yaichenbaum It is commited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
On the Recycle Bin page, there is no button to empty the Recycle Bin.
However, there is a New button which is never used. #6686
Details of Changes
On the Recycle Bin page, replace the button "New" by "Empty".
This button is only active if the Recycle Bin is not empty.
We can easily do the same for other pages.
@winston-de, can you give your opinion on my way of doing things?
Validation
How did you test these changes?