Skip to content

Conversation

cinqmilleans
Copy link
Contributor

Resolved / Related Issues
On the Recycle Bin page, there is no button to empty the Recycle Bin.
However, there is a New button which is never used. #6686

Details of Changes
On the Recycle Bin page, replace the button "New" by "Empty".
This button is only active if the Recycle Bin is not empty.

We can easily do the same for other pages.
@winston-de, can you give your opinion on my way of doing things?

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I added a couple comments on things I think should be adjusted.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Nov 3, 2021
@cinqmilleans
Copy link
Contributor Author

@yaichenbaum I applied the changes except showing the New button. I don't think showing it is a good idea. What does the community think?

@yaira2
Copy link
Member

yaira2 commented Nov 4, 2021

@yaichenbaum I applied the changes except showing the New button. I don't think showing it is a good idea. What does the community think?

I think it's best to avoid shifting the toolbar buttons.

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum What are we doing concretely?

@yaira2
Copy link
Member

yaira2 commented Nov 4, 2021

@yaichenbaum What are we doing concretely?

I think it's best to add the icons to the right of the toolbar for now and to add back the "new" button.

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum Ok for me. I would do that tomorrow.

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum It is commited.
I added a separator, hidden when there is no additional button. This code should make it easy to add more.
I put Visibility back instead of x: load. This caused an unpleasant visual effect, the button being active for a second before going gray when we reached an already empty Recycle Bin.

@yaira2 yaira2 self-requested a review November 5, 2021 18:27
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Nov 5, 2021
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Add Empty RecycleBin in inner toolbar Added a toolbar button to empty recycle bin Nov 7, 2021
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 7, 2021
@yaira2 yaira2 merged commit c67f241 into files-community:main Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants