Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 20, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Adds basic support for symlinks (the ones generated by e.g. > mklink dest_file.txt source_file.txt. Currently treated as Shortcut files.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested review from BanCrash and winston-de and removed request for winston-de November 20, 2021 23:38
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 20, 2021
Remove unnecessary imports
@BanCrash
Copy link
Contributor

BanCrash commented Nov 24, 2021

@gave92 if you open the shortcut properties with a symlink it won't let you use the Ok button:
GIF 24-11-2021 13-34-24

I guess shortcut properties should be only readable since the symlink can't be modified at the actual state. Hopefully that will also fixes the issue.

I mean, those fields should be read-only:
image

EDIT: Okay, this seems to be also on main with normal shortcuts, so it's not related to this PR.

@BanCrash BanCrash self-requested a review November 24, 2021 14:55
BanCrash
BanCrash previously approved these changes Nov 24, 2021
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 24, 2021
@gave92
Copy link
Member Author

gave92 commented Nov 24, 2021

I mean, those fields should be read-only

Totally agree, explorer does the same. Just did not want to do UI things in this PR =)

EDIT: Okay, this seems to be also on main with normal shortcuts, so it's not related to this PR.

Ouch, I'll look into this if I can

@yaira2
Copy link
Member

yaira2 commented Nov 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Merged latest changes
@BanCrash BanCrash added ready for review Pull requests that are ready for review and removed ready to merge Pull requests that are approved and ready to merge labels Nov 25, 2021
@BanCrash BanCrash self-requested a review November 25, 2021 10:30
@BanCrash
Copy link
Contributor

BanCrash commented Nov 25, 2021

@gave92 now it's not compiling because ItemNameRaw is not defined:
image

BTW, I don't know why the pipeline failed since I didn't have any issue while compiling lol.

@gave92
Copy link
Member Author

gave92 commented Nov 25, 2021

Yeah, I still need to merge main (it's defined on main)

@gave92
Copy link
Member Author

gave92 commented Nov 25, 2021

Ok, should be good now.

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 25, 2021
@yaira2 yaira2 merged commit fbc93a7 into files-community:main Nov 25, 2021
@yaira2 yaira2 mentioned this pull request Nov 25, 2021
@gave92 gave92 deleted the issue_6995 branch November 25, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper Symlink Support

3 participants