Fixed a bug where enter key does not work to confirm delete action #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, can you make the delete button before the cancel button? I'm suggesting this because according to the Windows User Interface Guidelines it is recommended to keep the primary button first. |
|
Can you add Space as well? Does the same thing as Enter, just a different method. |
|
@Jaiganeshkumaran @generalguy41 Both of those can be done, can you open an issue for each of them? |
|
@yaichenbaum My original ticket #877 has the Space request. Should I split that further along with the arrow keys? |
|
@Jaiganeshkumaran @generalguy41 Don't worry about the tickets, I will push the changes soon. |
lukeblevins
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.