Skip to content

Extend from React.Component (instead of React.PureComponent) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petermikitsh opened this issue Sep 25, 2018 · 1 comment · Fixed by #42
Closed

Extend from React.Component (instead of React.PureComponent) #41

petermikitsh opened this issue Sep 25, 2018 · 1 comment · Fixed by #42

Comments

@petermikitsh
Copy link
Contributor

Are you submitting a bug report or a feature request?

Eh, this feels kind of somewhere in the middle.

What is the current behavior?

FieldArray extends React.PureComponent.

What is the expected behavior?

FieldArray extends React.Component.

Sandbox Link

N/A

What's your environment?

N/A

Other information

For the reasons discussed in final-form/react-final-form#150, I'd like to see parity across all react-final-form* packages.

The tl,dr: I have external state I feed into my FieldArray render component. I also have to explicitly pass this state to FieldArray as a prop, so the component re-renders.
This was referenced Sep 26, 2018
Closed
Merged
@erikras
Copy link
Member

erikras commented Oct 16, 2018

Published in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FieldArray] extend React.Component petermikitsh/react-final-form-arrays
2 participants
@petermikitsh @erikras