Skip to content

provide custom isEqual function #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Conversation

maciejmyslinski
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          72     75    +3     
  Branches       16     17    +1     
=====================================
+ Hits           72     75    +3
Impacted Files Coverage Δ
src/FieldArray.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f945d...67b478c. Read the comment docs.

@maciejmyslinski
Copy link
Contributor Author

@anant-singh check this out 🙏

@erikras
Copy link
Member

erikras commented Oct 15, 2018

Your test doesn't check the actual isEqual prop passing, just that your default implementation works.

I've been working on another branch that does use that, but I was not passing a default shallow equal implementation. I think your default implementation is a reasonable default. So I'm going to merge this and then my test.

@maciejmyslinski
Copy link
Contributor Author

Thanks for feedback @erikras. I agree those tests could be improved. Should I improve them or will your test suffice?

@erikras
Copy link
Member

erikras commented Oct 15, 2018

I'll get it.

@erikras erikras merged commit 5019141 into final-form:master Oct 15, 2018
erikras added a commit that referenced this pull request Oct 15, 2018
erikras added a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants