Documented and Typed fields.value #96
Merged
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 57 57
Branches 10 10
=====================================
Hits 57 57Continue to review full report at Codecov.
|
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the hooks rewrite,
fields.valuehas been present, but it was undocumented and untyped. This PR remedies that.It's a shame that there's no good way to force it to be readonly/immutable. I guess we'll just have to hope devs are smart enough to not try to use
fields.push()rather thanfields.value.push().Fixes #95. Fixes #13.