Adding temporary workaround to call FirebaseAuth completion block in … #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol86
approved these changes
Sep 22, 2017
XiangtianDai
approved these changes
Sep 22, 2017
morganchen12
approved these changes
Sep 22, 2017
| if ([NSThread isMainThread]) { | ||
| completionBlock(); | ||
| } else { | ||
| dispatch_sync(dispatch_get_main_queue(), completionBlock); |
There was a problem hiding this comment.
I missed this earlier... I think we'd better to do dispatch_async instead of dispatch_sync, otherwise if the delegate calls FIRAuth methods there is a risk of deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to fix firebase/firebase-ios-sdk#304