Skip to content

chore: Running CI workflow on pull_request #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

hiranya911
Copy link
Contributor

Unless we trigger this workflow on pull_request event, we won't get CI coverage for pull requests sent by external contributors.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@hiranya911 hiranya911 merged commit 0e690ec into dev Feb 25, 2020
@hiranya911 hiranya911 deleted the hiranya911-patch-1 branch February 25, 2020 21:38
hiranya911 added a commit that referenced this pull request Apr 23, 2020
* chore: Removed Travis CI integration (#326)

* chore: Added Actions-based release workflow (#331)

* chore: Added Actions-based release workflow

* Set GOPATH

* Fixed working directory for tests

* Decrypting credentials into the testdata directory

* Added preflight and post check scripts

* chore: Running CI workflow on pull_request (#338)

* fix(fcm): correct the iidEndpoint endpoints used for topic management (#335)

According to the document https://developers.google.com/instance-id/reference/server,
the endpoints should be:

https://iid.googleapis.com/iid/v1:batchAdd
https://iid.googleapis.com/iid/v1:batchRemove

NOT:

https://iid.googleapis.com/iid/v1/:batchAdd
https://iid.googleapis.com/iid/v1/:batchRemove

* fix(fcm): Fix documents of FCM batch request limit (#347)

Co-authored-by: Hiranya Jayathilaka <[email protected]>

* fix: Deferring credential loading until required (#361)

* Bumped version to 3.12.1 (#363)

* chore: Specifying correct working directory for staging command (#365)

Co-authored-by: Rueian <[email protected]>
Co-authored-by: 178inaba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants