Skip to content

FR:TopicManagementResponse$Error should have toString() method(for logging) #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shambhand opened this issue Jan 8, 2020 · 3 comments
Closed

FR:TopicManagementResponse$Error should have toString() method(for logging) #343

shambhand opened this issue Jan 8, 2020 · 3 comments
Labels
api: messaging help wanted type: feature request

Comments

@shambhand
Copy link
Contributor

shambhand commented Jan 8, 2020 •
edited
Loading

Add toString() in TopicManagementResponse$Error to print the error response from firebase.
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

@shambhand shambhand changed the title TopicManagementResponse$Error should have toString() method(for logging) FR:TopicManagementResponse$Error should have toString() method(for logging) Jan 8, 2020
@hiranya911
Copy link
Contributor

Sounds reasonable to me. Feel free to submit a PR. Otherwise I'll get to it when I have some free cycles.

shambhand added a commit to shambhand/firebase-admin-java that referenced this issue Aug 8, 2020
@shambhand
Added toString() in TopicManagementResponse for logging (firebase#343)
6001e1a
hiranya911 pushed a commit that referenced this issue Aug 10, 2020
@shambhand
fix(fcm): Added toString() in TopicManagementResponse for logging (#469)
8c86411 
* Added toString() in TopicManagementResponse for logging (#343)

* Used MoreObjects.toStringHelper()

* removed .DS_Store & added it to .gitignore

* unit test case for TopicManagementResponse toString() functionality added for logging

* fixed checkStyle issue of line should not greater than 100 char
@hiranya911
Copy link
Contributor

Fixed in #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: messaging help wanted type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hiranya911 @google-oss-bot @shambhand