Skip to content

fix(fcm): Fix issues in event_time timestamp parsing #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2019

Conversation

chong-shao
Copy link
Contributor

@chong-shao chong-shao commented Dec 19, 2019

  • Set the timezone to always be UTC.
  • Pending zeros after the millisecond digits to the right instead of left.

RELEASE NOTE: AndroidNotification class now correctly formats the event_time field sent to the Cloud Messaging service.

Resolves #337

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo/bug pointed out.

@hiranya911 hiranya911 changed the title Fix issues in event_time timestamp parsing fix(fcm): Fix issues in event_time timestamp parsing Dec 19, 2019
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chong-shao chong-shao merged commit 78852a9 into master Dec 19, 2019
@chong-shao chong-shao deleted the fix_timestamp branch December 19, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect timestamp format in AndroidNotification.event_time
2 participants