Skip to content

feat(auth): Support for creating tenant-scoped session cookies #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

hiranya911
Copy link
Contributor

  • Upgraded some Maven plugins to latest to avoid some issues with Jacoco code coverage reporting in older versions.
  • Cleaned up the Builder APIs in FirebaseAuth and TenantAwareFirebaseAuth.
  • Moved session cookie creation and verification APIs to AbstractFirebaseAuth so they are inherited by both subclasses of this API.
  • Implemented support for verifying tenant-scoped session cookies (by passing a tenant ID to the respective FirebaseTokenVerifier).
  • Implemented support for creating tenant-scoped session cookies (by verifying the ID token locally which also matches tenant IDs)

RELEASE NOTE: Exposing createSessionCookie() and verifySessionCookie() methods from the TenantAwareFirebaseAuth class.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Should we get the new docs reviewed?

@hiranya911
Copy link
Contributor Author

Those are existing docs. We are just moving them from FirebaseAuth to AbstractFirebaseAuth. I'm also debating whether to merge this PR now or finish off the v7 work first. I'll figure it out next week.

@hiranya911 hiranya911 merged commit 3564eeb into master Aug 10, 2020
@hiranya911 hiranya911 deleted the hkj-mt-cookies branch August 10, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants