Adds @license JSDoc tag to license comments #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lahirumaramba please merge this when ready. I don't think @nathanmosher has write access on this repo. |
Sounds good! I started the process. |
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
Adds @license JSDoc tag to license comments
This was referenced Jun 2, 2024
This was referenced Jun 19, 2024
This was referenced Jul 17, 2024
This was referenced Jul 27, 2024
This was referenced Aug 2, 2024
This was referenced Aug 10, 2024
This was referenced Aug 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 5, 2024
This was referenced Sep 24, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just hoping to get this license tag submitted upstream to help this code play a bit better with the NodeJS import tools internally (at Google). The change will help a Google3 import script know that a comment block is, in fact, a license comment block.
There's a few trailing whitespaces my editor really wanted to remove too, lmk if I should revert them, and if you need more context.