Removing getCertificate() from the Credential interface #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential
is a public interface and is declared as follows in the typings:But in the actual implementation (credential.ts), there's an additional method in the interface:
firebase-admin-node/src/auth/credential.ts
Lines 291 to 294 in 843df12
This can cause issues if the developer implements the public
Credential
interface, and passes it throughAppOptions
. Internal code that expects to find agetCertificate()
method will fail.This PR addresses this issue by separating the
getCertificate()
method from theCredential
interface.Resolves #573