Skip to content

make @firebase/app a devDependency #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2019
Merged

make @firebase/app a devDependency #586

merged 4 commits into from
Jul 12, 2019

Conversation

Feiyang1
Copy link
Member

It's a sibling PR to firebase/firebase-js-sdk#1916

@Feiyang1 Feiyang1 mentioned this pull request Jun 25, 2019
Merged
@Feiyang1
Copy link
Member Author

@hiranya911 This PR is now ready to be merged.

hiranya911
hiranya911 approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@hiranya911 hiranya911 assigned Feiyang1 and unassigned hiranya911 Jul 12, 2019
@Feiyang1 Feiyang1 merged commit cc67d08 into master Jul 12, 2019
@Feiyang1 Feiyang1 deleted the fei-admin-compat branch July 12, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feiyang1 @hiranya911