Skip to content

#61 add support to shallow param #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

rodolphopivetta
Copy link

I just added the param to shallow results

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rodolphopivetta
Copy link
Author

Google CLA account created

@googlebot
Copy link

CLAs look good, thanks!

@rodolphopivetta
Copy link
Author

rodolphopivetta commented Oct 17, 2017

Failed test solved in commit rodolphopivetta@3bc92f4 but the PR did not update

@hiranya911
Copy link
Contributor

hiranya911 commented Oct 17, 2017

Thanks @rodolphopivetta

Please fix the linter error detected by CI: https://travis-ci.org/firebase/firebase-admin-python/builds/289052233. You can run ./lint.sh all locally to see what the output is like.

And please provide unit tests (at leasts), and integration tests to verify the new functionality.

@hiranya911 hiranya911 self-requested a review October 17, 2017 23:32
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodolphopivetta. Implementation looks good. If you can provide at least a unit test, I can accept this PR. I can take care of updating the integration tests.

@rodolphopivetta
Copy link
Author

I'll asap @hiranya911. Thanks

@hiranya911
Copy link
Contributor

Closing in favor of #109. Thanks @rodolphopivetta for the contribution.

@hiranya911 hiranya911 closed this Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants