-
Notifications
You must be signed in to change notification settings - Fork 339
#61 add support to shallow param #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Google CLA account created |
CLAs look good, thanks! |
Failed test solved in commit rodolphopivetta@3bc92f4 but the PR did not update |
Thanks @rodolphopivetta Please fix the linter error detected by CI: https://travis-ci.org/firebase/firebase-admin-python/builds/289052233. You can run And please provide unit tests (at leasts), and integration tests to verify the new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodolphopivetta. Implementation looks good. If you can provide at least a unit test, I can accept this PR. I can take care of updating the integration tests.
I'll asap @hiranya911. Thanks |
Closing in favor of #109. Thanks @rodolphopivetta for the contribution. |
I just added the param to shallow results