Skip to content

Adding get Model for local downloads #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 3, 2020
Merged

Adding get Model for local downloads #2212

merged 11 commits into from
Dec 3, 2020

Conversation

annzimmer
Copy link
Contributor

…nconditional downloads at this time.

@googlebot googlebot added the cla: yes Override cla label Nov 30, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (00e6a8d) and head commit (49bc16a5).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (49bc16a5) is created by Prow via merging commits: 00e6a8d a838a77.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-ml-modeldownloader:
error: Method com.google.firebase.ml.modeldownloader.CustomModel.getFile added thrown exception java.lang.Exception [ChangedThrows]
error: Method com.google.firebase.ml.modeldownloader.FirebaseModelDownloader.getModel added thrown exception java.lang.Exception [ChangedThrows]
error: Added package com.google.firebase.ml.modeldownloader.internal [AddedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-ml-modeldownloader

    Type Base (00e6a8d) Head (97e3b0d6) Diff
    aar 21.5 kB 35.5 kB +14.0 kB (+65.3%)
    apk (aggressive) 83.7 kB 84.1 kB +368 B (+0.4%)
    apk (release) 698 kB 703 kB +4.86 kB (+0.7%)

Test Logs

Notes

Head commit (97e3b0d6) is created by Prow via merging commits: 00e6a8d 999a7dc.

@annzimmer annzimmer marked this pull request as ready for review December 1, 2020 21:49
@annzimmer annzimmer requested review from vkryachko and rlazo December 1, 2020 21:49
rlazo
rlazo reviewed Dec 2, 2020
View reviewed changes
.../src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileDownloadService.java
try {
fileDescriptor = downloadManager.openDownloadedFile(downloadingId);
} catch (FileNotFoundException e) {
System.out.println("Downloaded file is not found");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - changing all these to logs in the next major PR. Just started working on it this morning.

.../src/main/java/com/google/firebase/ml/modeldownloader/internal/ModelFileDownloadService.java
}

if (statusCode == DownloadManager.STATUS_SUCCESSFUL) {
System.out.println("Download Succeeded for id: " + id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

annzimmer and others added 3 commits December 2, 2020 09:32
@annzimmer @rlazo
Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/…
2f8dc9d 
…ml/modeldownloader/CustomModel.java

Co-authored-by: Rodrigo Lazo <[email protected]>
@annzimmer @rlazo
Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/…
ad66c71 
…ml/modeldownloader/FirebaseModelDownloader.java

Co-authored-by: Rodrigo Lazo <[email protected]>
@annzimmer @rlazo
Update firebase-ml-modeldownloader/src/main/java/com/google/firebase/…
adba84f 
…ml/modeldownloader/internal/ModelFileManager.java

Co-authored-by: Rodrigo Lazo <[email protected]>
@annzimmer
Copy link
Contributor Author

/test smoke-tests

1 similar comment
@annzimmer
Copy link
Contributor Author

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@annzimmer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 999a7dc link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented Dec 3, 2020

@annzimmer BTW smoke-tests have been broken for a couple of days. @yifanyang can confirm whether this failure is related to that issues and if it's safe to ignore

@yifanyang
Copy link
Contributor

@annzimmer BTW smoke-tests have been broken for a couple of days. @yifanyang can confirm whether this failure is related to that issues and if it's safe to ignore

Yes, the smoke test has been failing since last weekend. I'm investigating/fixing multiple causes to it. This PR should have nothing to do with the failure.

@annzimmer annzimmer merged commit 1deb532 into master Dec 3, 2020
@firebase firebase locked and limited conversation to collaborators Jan 3, 2021
@kaibolay kaibolay deleted the fileDownload branch September 15, 2022 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees

@pavelgj pavelgj

@manjanac manjanac

@annzimmer annzimmer

Labels
cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@annzimmer @google-oss-bot @rlazo @yifanyang @pavelgj @googlebot @manjanac