Skip to content

RTDB Query get method must be public #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

RTDB Query get method must be public #2231

merged 1 commit into from
Dec 4, 2020

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Dec 4, 2020

This is a typo that slipped through in the original PR #2087

@google-cla google-cla bot added the cla: yes Override cla label Dec 4, 2020
@jmwski jmwski merged commit 8a327a7 into master Dec 4, 2020
@jmwski jmwski deleted the jw/get-public branch December 4, 2020 22:39
@jmwski jmwski assigned jmwski and unassigned schmidt-sebastian Dec 4, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.33% (1deb532) to 50.35% (879da7ad) by +0.02%.

    Filename Base (1deb532) Head (879da7ad) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    RetryHelper.java 74.19% 70.97% -3.23%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (879da7ad) is created by Prow via merging commits: 1deb532 0a2400d.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-database:
error: Added method com.google.firebase.database.Query.get() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-database

    Type Base (1deb532) Head (879da7ad) Diff
    aar 490 kB 490 kB +2 B (+0.0%)

Test Logs

Notes

Head commit (879da7ad) is created by Prow via merging commits: 1deb532 0a2400d.

@google-oss-bot
Copy link
Contributor

@IanWyszynski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 0a2400d link /test api-information
smoke-tests 0a2400d link /test smoke-tests
device-check-changed 0a2400d link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vkryachko pushed a commit that referenced this pull request Dec 15, 2020
@rlazo @jmwski @schmidt-sebastian
Cherry pick RTDB fixes for M85 (#330)
8c321f0 
* RTDB Query get method must be public (#2231)

* Don't crash SDK is socket.close() fails (#2216)

Co-authored-by: Jan Wyszynski <[email protected]>
Co-authored-by: Sebastian Schmidt <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@jmwski jmwski

Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmwski @google-oss-bot @schmidt-sebastian