Skip to content

Remove held batch handling from LocalStore #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

This PR removes the notion of held write acks from LocalStore.

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check 5bd477e link /test check
connected-check 5bd477e link /test connected-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit c544bdc into firestore-held-write-acks Sep 21, 2018
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-removeacks branch October 15, 2018 17:25
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants