Skip to content

Adding onSnapshotsInSync (not public) #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2019
Merged

Adding onSnapshotsInSync (not public) #778

merged 5 commits into from
Sep 10, 2019

Conversation

thebrianchen
Copy link

Porting from web.

@googlebot googlebot added the cla: yes Override cla label Sep 9, 2019
mikelehen
mikelehen approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple tiny nits!

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Sep 10, 2019
@thebrianchen thebrianchen merged commit d0d0b1c into master Sep 10, 2019
@rlazo rlazo deleted the bc/global-snapshots branch October 3, 2019 14:44
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @mikelehen @googlebot @google-oss-bot