Skip to content

Commit 48e5f7a

Browse files
authored
enable disabled passed integration test (#2120)
* enable disabled passed integration test * address comment
1 parent 305f872 commit 48e5f7a

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

Firestore/Example/Tests/Integration/FSTTransactionTests.mm

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ @interface FSTTransactionTests : FSTIntegrationTestCase
2626

2727
@implementation FSTTransactionTests
2828

29-
// We currently require every document read to also be written.
30-
// TODO(b/34879758): Re-enable this test once we fix it.
31-
- (void)xtestGetDocuments {
29+
- (void)testGetDocuments {
3230
FIRFirestore *firestore = [self firestore];
3331
FIRDocumentReference *doc = [[firestore collectionWithPath:@"spaces"] documentWithAutoID];
3432
[self writeDocumentRef:doc data:@{@"foo" : @1, @"desc" : @"Stuff", @"owner" : @"Jonny"}];
@@ -334,9 +332,7 @@ - (void)testUpdateTransactionally {
334332
XCTAssertEqualObjects(@"yes", snapshot[@"other"]);
335333
}
336334

337-
// We currently require every document read to also be written.
338-
// TODO(b/34879758): Re-enable this test once we fix it.
339-
- (void)xtestHandleReadingOneDocAndWritingAnother {
335+
- (void)testHandleReadingOneDocAndWritingAnother {
340336
FIRFirestore *firestore = [self firestore];
341337
FIRDocumentReference *doc1 = [[firestore collectionWithPath:@"counters"] documentWithAutoID];
342338
FIRDocumentReference *doc2 = [[firestore collectionWithPath:@"counters"] documentWithAutoID];
@@ -423,9 +419,7 @@ - (void)testReadingADocTwiceWithDifferentVersions {
423419
XCTAssertEqualObjects(@(1234.0), snapshot[@"count"]);
424420
}
425421

426-
// We currently require every document read to also be written.
427-
// TODO(b/34879758): Add this test back once we fix that.
428-
- (void)xtestCannotHaveAGetWithoutMutations {
422+
- (void)testCannotHaveAGetWithoutMutations {
429423
FIRFirestore *firestore = [self firestore];
430424
FIRDocumentReference *doc = [[firestore collectionWithPath:@"foo"] documentWithAutoID];
431425
[self writeDocumentRef:doc data:@{@"foo" : @"bar"}];
@@ -438,6 +432,8 @@ - (void)xtestCannotHaveAGetWithoutMutations {
438432
return nil;
439433
}
440434
completion:^(id _Nullable result, NSError *_Nullable error) {
435+
// We currently require every document read to also be written.
436+
// TODO(b/34879758): Fix this check once we drop that requirement.
441437
XCTAssertNotNil(error);
442438
[expectation fulfill];
443439
}];

0 commit comments

Comments
 (0)