enable disabled passed integration test #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsgowman
approved these changes
Nov 26, 2018
| @@ -28,7 +28,7 @@ @implementation FSTTransactionTests | |||
|
|
|||
| // We currently require every document read to also be written. | |||
| // TODO(b/34879758): Re-enable this test once we fix it. | |||
| - (void)xtestGetDocuments { | |||
| - (void)testGetDocuments { | |||
There was a problem hiding this comment.
I'd recommend removing the TODO on the line above as it no longer makes sense (there's nothing to re-enable). There's already a TODO for this issue within the body (line 46)
| @@ -336,7 +336,7 @@ - (void)testUpdateTransactionally { | |||
|
|
|||
| // We currently require every document read to also be written. | |||
| // TODO(b/34879758): Re-enable this test once we fix it. | |||
| - (void)xtestHandleReadingOneDocAndWritingAnother { | |||
| - (void)testHandleReadingOneDocAndWritingAnother { | |||
| @@ -425,7 +425,7 @@ - (void)testReadingADocTwiceWithDifferentVersions { | |||
|
|
|||
| // We currently require every document read to also be written. | |||
| // TODO(b/34879758): Add this test back once we fix that. | |||
| - (void)xtestCannotHaveAGetWithoutMutations { | |||
| - (void)testCannotHaveAGetWithoutMutations { | |||
There was a problem hiding this comment.
Similar to as above, but slightly different. In this test, there's no todo in teh body. So I'd recommend removing the TODO comment (like the others) but add in a TODO after line 440, similar to the first test.
var-const
approved these changes
Nov 26, 2018
bstpierr
added a commit
that referenced
this pull request
Nov 27, 2018
* Revert "Custom fdl domain (#2121)" This reverts commit ebea1ef. * Revert "enable disabled passed integration test (#2120)" This reverts commit 48e5f7a. * Revert "Wire together LRU GC (#1905)" This reverts commit 305f872. * Revert "Fix build under linux/gcc (#2116)" This reverts commit b0a4b6c. * Revert "Implement PatchMutation::ApplyToLocalView (#1973)" This reverts commit f66b5b5. * Revert "Add Firebase Source to Header Search Path (#2114)" This reverts commit 0540361.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable test cases. These three integration test cases are disabled. They are passing now in the sense the test case has modified consistent with the other platform. Although the bug in the TODO is still yet fixed and thus not removing that comment (it is possible once the TODO is fixed the logic in the test needs to be updated).