FIRMessagingRemoteNotificationsProxyTest.m:testListeningForDelegateChangesOnInvalidUserNotificationCenter invalid test

[dmaclach]

Description

https://github.com/firebase/firebase-ios-sdk/blob/e58e322f2ca7618aa81b215de4526d658ea1329a/FirebaseMessaging/Tests/UnitTests/FIRMessagingRemoteNotificationsProxyTest.m#L277C9-L277C71 is an invalid test.

1. It sets a stub on a mock that is already stubbed for that method. That will fail silently
2. it is calling a method on the delegate which is nil which will do nothing.

It will pass because it is based on OCMReject but since nothing is called this will always pass.

Reproducing the issue

N/A

Firebase SDK Version

All (tests)

Xcode Version

16

Installation Method

N/A

Firebase Product(s)

Messaging

Targeted Platforms

All

Relevant Log Output

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[rizafran]

Hi, per checking, the PR was merged to main and already included in v11.15.0. I'll now be closing this ticket. Thanks!