iOS 13 Crash - [FIRInstanceIDKeychain itemWithQuery:]

[milo-]

• Xcode version: 10.2.1
• Firebase SDK version: 6.3.0
• Firebase Component: Core (Auth, Core, Database, Firestore, Messaging, Storage, etc)
• Component version: 6.3.0

Describe the problem

We released an update yesterday, going from Firebase 6.0.0 to firebase 6.3.0. We've been getting reports of the app crashing on startup for users with iOS 13 beta (17A5508m).

We've not been able to reproduce this ourselves, but we've had at least 5 crashes in the last 12 hours caused by this. Users have reported that uninstalling and reinstalling the app doesn't fix things.

The thread that crashes:

Thread 10 Crashed:
0   libdispatch.dylib             	0x00000001c3caebe0 __DISPATCH_WAIT_FOR_QUEUE__ + 452 (queue.c:1615)
1   libdispatch.dylib             	0x00000001c3cae758 _dispatch_sync_f_slow + 144 (queue.c:1728)
2   App                     	0x0000000102764448 -[FIRRemoteConfig configValueForKey:namespace:] + 220
3   App                     	0x00000001026dedb8 -[FPRRemoteConfigFlags sessionSamplingRate] + 60
4   App                     	0x00000001026de44c -[FPRConfigurations sessionsSamplingPercentage] + 212
5   App                     	0x00000001026d7ec4 -[FPRSessionManager isGaugeCollectionEnabledForSessionId:] + 60
6   App                     	0x00000001026d7d4c -[FPRSessionManager updateSessionId:] + 292
7   App                     	0x00000001026d7a6c -[FPRSessionManager initWithNotificationCenter:] + 128
8   App                     	0x00000001026d79c8 __35+[FPRSessionManager sharedInstance]_block_invoke + 84
9   libdispatch.dylib             	0x00000001c3ca2114 _dispatch_client_callout + 20 (object.m:495)
10  libdispatch.dylib             	0x00000001c3ca37f0 _dispatch_once_callout + 32 (once.c:52)
11  App                     	0x00000001026d796c +[FPRSessionManager sharedInstance] + 56
12  App                     	0x00000001026e987c -[FPRNetworkTrace start] + 228
13  App                     	0x00000001026f0870 __InstrumentDataTaskWithRequestCompletionHandler_block_invoke + 368
14  App                     	0x00000001026f07ec __InstrumentDataTaskWithRequestCompletionHandler_block_invoke + 236
15  App                     	0x00000001026a7930 -[FIRInstanceIDCheckinService checkinWithExistingCheckin:completion:] + 652 (FIRInstanceIDCheckinService.m:189)
16  App                     	0x00000001026a509c -[FIRInstanceIDAuthService fetchCheckinInfoWithHandler:] + 496 (FIRInstanceIDAuthService.m:188)
17  App                     	0x000000010269e648 -[FIRInstanceID tokenWithAuthorizedEntity:scope:options:handler:] + 1092 (FIRInstanceID.m:324)
18  App                     	0x00000001027729fc -[RCNConfigFetch refreshInstanceIDTokenAndFetchCheckInInfoWithCompletionHandler:] + 392
19  App                     	0x00000001027725c8 __74-[RCNConfigFetch fetchAllConfigsWithExpirationDuration:completionHandler:]_block_invoke + 288
20  libdispatch.dylib             	0x00000001c3ca0cb8 _dispatch_call_block_and_release + 32 (init.c:1408)
21  libdispatch.dylib             	0x00000001c3ca2114 _dispatch_client_callout + 20 (object.m:495)
22  libdispatch.dylib             	0x00000001c3ca8534 _dispatch_lane_serial_drain + 568 (inline_internal.h:2487)
23  libdispatch.dylib             	0x00000001c3ca8f5c _dispatch_lane_invoke + 364 (inline_internal.h:1854)
24  libdispatch.dylib             	0x00000001c3cb1fd0 _dispatch_workloop_worker_thread + 580 (queue.c:6380)
25  libsystem_pthread.dylib       	0x00000001c3cdfa64 _pthread_wqthread + 308 (pthread.c:2329)
26  libsystem_pthread.dylib       	0x00000001c3ce5c44 start_wqthread + 8

I've attached the full crash log, let me know if I can provide any more info

2019-06-27_02-12-29.9158_+0100-8692347274dbd966774cf859c53577c33a82cbb0.txt

[mouness2020]

also firebase remote config crash in iOS13 .
test_issue_crash_0cbd0e86b7fd44d98dac238ea687bb09_DNE_0_v2.txt
test2_issue_crash_1668e1b4c3a24090b2ecf6a4eb157017_DNE_0_v2.txt

[ozzotto]

Same crash for me too.

[morganchen12]

I'm looking into this issue. It seems to be caused by a deadlock in RemoteConfig and InstanceID. Will keep this thread updated with details.

[kross51]

I also have a crash on iOS 13:

libdispatch.dylib`DISPATCH_WAIT_FOR_QUEUE:
0x105a96414 <+0>: pacibsp
...
0x105a965e4 <+464>: ldp x20, x21, [sp], #0x10
-> 0x105a965e8 <+468>: brk #0x1

dump.txt

[morganchen12]

@maksymmalyhin reassigning to you since I'm going on vacation next week. I wasn't able to conclusively prove this crash is caused by a deadlock. Here's what I've figured out thus far:

• The crash is always at launch (+[FIRApp configure] is always in the stack trace).
• The crash always occurs in a background thread on a dispatch_wait after a dispatch_sync, called from RemoteConfig.
• The crash involves fetching data from keychain, and may be a regression of Crash and rejection from the App Store: scene-create watchdog transgression #1399.
• The stack trace usually includes a dispatch_sync on the main thread, called from InstanceID.

Feel free to assign it back to me when I return from vacation on July 8th.

[seanpai96]

I’m also experiencing this problem and I would like to help. What info can I provide?