Skip to content

GDTStorage encodeWithCoder crash on firebase 6.6.0 #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aporat opened this issue Aug 18, 2019 · 13 comments
Closed

GDTStorage encodeWithCoder crash on firebase 6.6.0 #3623

aporat opened this issue Aug 18, 2019 · 13 comments
Assignees
Milestone

Comments

@aporat
Copy link

aporat commented Aug 18, 2019

Xcode version: 10.3
Firebase SDK version: 6.6.0
Firebase Component:
Using FirebaseAnalytics (6.1.0)
Using FirebaseAuth (6.2.2)
Using FirebaseCore (6.2.0)
Using FirebaseCoreDiagnostics (1.0.1)
Using FirebaseCoreDiagnosticsInterop (1.0.0)
Using Google-Mobile-Ads-SDK (7.48.0)
Using GoogleAppMeasurement (6.1.0)
Using GoogleDataTransport (1.1.1)
Using GoogleDataTransportCCTSupport (1.0.1)
Using GoogleUtilities (6.2.5)

Problem:
multiple crashes from fabric reporting. this does not happens on firebase 6.5.0
GDTStorage.m line 268
-[GDTStorage encodeWithCoder:]

probably related to #3547

seen the same crashes happening with GoogleDataTransport 1.0.0 as well

crash.txt

@google-oss-bot

This comment has been minimized.

@paulb777
Copy link
Member

@aporat Thanks for the report. I suspect the problem is more likely related to #3525 - migrating to the modern NSKeyedArchiver APIs.

Are you able to reproduce or see any patterns from the crash reports?

@aporat
Copy link
Author

aporat commented Aug 18, 2019

I can see that around 80% of the crashes happen when the app is in the background state. so while there are relative high amount of crashes, I assume it's not causing such a hassle for actual users.

I reverted to 6.5.0 for a little while just to be sure.

@mikehaney24
Copy link
Contributor

@aporat Thanks for the report. I suspect the problem is more likely related to #3525 - migrating to the modern NSKeyedArchiver APIs.

I think the linked code hasn't shipped yet, but will very soon.

@paulb777
Copy link
Member

I'll close, since we expect this to be addressed with #3525 along with this week's 6.7.0 release.

@paulb777 paulb777 added this to the 6.7.0 milestone Aug 19, 2019
@paulb777 paulb777 reopened this Aug 19, 2019
@paulb777
Copy link
Member

We've reproduced and it is a different bug. We're investigating and will try to get the fix into 6.7.0.

@mikehaney24
Copy link
Contributor

mikehaney24 commented Aug 19, 2019

This bug should be addressed by #3627, it was closely associated with another bug report, and as both were symptoms of the same bug (threading issues whilst backgrounding in GDTStorage). Feel free to reopen if it is still occurring after 6.7.0.

@Banck
Copy link

Banck commented Aug 21, 2019

@paulb777 Hey! When will you bump version in coocapods to 6.7.0 without this crash?
Thanks

@kk-cust-ios
Copy link

when update firebase for 6.7.0 ?

@mikehaney24
Copy link
Contributor

Firebase 6.7.0 has been released.

@wimbledon
Copy link

wimbledon commented Aug 22, 2019 via email

@paulb777
Copy link
Member

@wimbledon Thanks, we're investigating the why the website didn't update. In the meantime, 6.7.0 is available on CocoaPods and by zip at https://github.com/firebase/firebase-ios-sdk/releases/tag/6.7.0

@morganchen12
Copy link
Contributor

@wimbledon the website has been updated. If you see any more stale files, please let us know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants