-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Crash in FIRMutableDictonary #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you able to reproduce with fewer Firebase pods in use to narrow down the scope? In particular, I'm wondering if this crash is dependent upon FirebasePerformance like #486. |
I haven't seen the issue again today, so it may be dependent on receiving corrupt or incomplete data from the server. If/when it starts happening again I will remove Firebase PODs to try and isolate it. Thanks Paul! |
@jlaws also, if there are any non-Firebase pods in use that would be helpful too! |
Here is a list of all the pods I use: AKNumericFormatter (0.0.2) |
Also, its happening again, trying to isolate it to a pod now |
It appears FirebasePerformance is the problematic pod. The problem disappears when FirebasePerformance is no longer part of my project. Luckily I don't really use any of the performance tools (yet) so I will leave it off for now. |
@jlaws Thanks for narrowing it down! The issue may be an duplicate of #486 which is being fixed in the next FirebasePerformance release. cc: @mikehaney24 |
We're not sure this is a duplicate issue (though we hope it's fixed next release). So, we're tracking this internally with b/70392677. |
@jlaws Do you still see this with FirebasePerformance 1.1.0? |
Re-enabling the pod, will try it out for our next release and let you know |
Still causing the crash, removed the pod again |
Thanks @jlaws! We'll investigate. |
In my case, it's happening when I use along with AppDynamics. Doing more investigation. I'm using FirebaseAnalytics (4.0.3) |
I'm showing a crash on start involving using AppDynamics with FirebaseAnalytics, stack trace looks like this:
Do you see this anywhere in your app? |
Yes, just disable Firebase method swizzling option, that will solve the problem. |
Which option, specifically? |
https://firebase.google.com/docs/cloud-messaging/ios/client |
@mikehaney24 : The crash seems to be a different cause from FIRMutableDictionary, right? It looks like AppDynamics SDK swizzles the UIApplication class setDelegate: and causes the conflict. |
Yeah, I suspect an AppDelegate swizzling conflict, and don't think it's
related to FIRMutableDictionary. I have a test project that repros the
issue, we can talk about it on Monday if you want!
…On Sat, Feb 24, 2018 at 3:40 PM Alex Do ***@***.***> wrote:
@mikehaney24 <https://github.com/mikehaney24> : The crash seems to be a
different cause from FIRMutableDictionary, right? It looks like AppDynamics
SDK swizzles the UIApplication class setDelegate: and causes the conflict.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#529 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCFgmxxo46jYxOidVYtvIvb6O68whACks5tYJ3WgaJpZM4Q1wJz>
.
|
We have created a bug internally. If it's not related to FIRMutableDictionary, we shouldn't discuss it here. We will discuss about the swizzling offline. I do think it's AppDynamics problem, not ours though if they swizzle setDelegate of UIApplication. |
It looks like this crash may be rooted in AppDynamic's swizzling of setDelegate:, and I don't think we'll be able to do much about this. Does the original crash issue you were having go away if you remove AppDynamics? If so, it just might be the case that Google Analytics for Firebase and AppDynamics are incompatible at this time. |
I encountered the same issue, but after a couple of rebuilds, it "went away".
|
Closing due to lack of recent activity. Please reopen if still an issue. |
@baolocdo @mikehaney24 I've seen this crash twice today in the Analytics quickstart that I just left running in the background. The last thing in the log is
|
Does it happen with Analytics + Perf or Analytics only? I suspect that there is some interaction with Perf that might cause the issue. I'll try to reproduce once I have some bandwidth. Thanks |
I only see it with Analytics + Perf. |
note: the original stack trace in this issue is nearly identical to this stack trace. Is this still an issue? |
Closing for staleness. |
Describe the environment
Xcode version: 9.2
Firebase (4.7.0)
Issue is in code from this POD:
FirebaseCore (4.0.12)
Other Firebase PODs installed:
FirebaseABTesting (1.0.0)
FirebaseAnalytics (4.0.5)
FirebaseAuth (4.4.0)
FirebaseDatabase (4.1.2)
FirebaseDynamicLinks (2.3.0)
FirebaseInstanceID (2.0.7)
FirebaseMessaging (2.0.7)
FirebasePerformance (1.0.7)
FirebaseRemoteConfig (2.1.0)
FirebaseStorage (2.1.0)
FirebaseSwizzlingUtilities (1.0.0)
Describe the problem
The app crashes shortly after launch on a cold start. It happens every 1/5 cold starts. No user interaction, just starting the app and seeing what happens.
Here is the crashing stack trace:
The text was updated successfully, but these errors were encountered: