Skip to content

Trying to use the source pod integration #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nico75005 opened this issue Jan 24, 2018 · 4 comments
Closed

Trying to use the source pod integration #702

nico75005 opened this issue Jan 24, 2018 · 4 comments
Assignees

Comments

@nico75005
Copy link

nico75005 commented Jan 24, 2018

  • Xcode version: 9.2 (9C40b)
  • Firebase SDK version: 4.8.1
  • Firebase Component: Firestore
  • Component version: 0.10.0

I am trying to use the source pod integration but once I do and try to compile I get an error.

So here are my pods:

pod 'Firebase/Core'
pod 'Firebase/Storage'
pod 'Firebase/Auth'
pod 'Firebase/Database'
pod 'Firebase/Firestore'
pod 'Firebase/Messaging'
pod 'Firebase/RemoteConfig'
pod 'FirebaseFirestore', :git => 'https://github.com/firebase/firebase-ios-sdk.git'

Now I can see the sources that have replaced the binary framework.
But when I try to compile it, I get the following error:

MyProject/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/util/comparison.h:32:10: 'absl/strings/string_view.h' file not found
@wilhuff
Copy link
Contributor

wilhuff commented Jan 24, 2018

We've been making a lot of changes in this area lately so it's possible this has been broken. Was this working previously or are you trying for the first time?

Meanwhile I'll look at reproducing this. Our own development runs in-repo which may mean that our HEADER_SEARCH_PATHS are broken.

@wilhuff
Copy link
Contributor

wilhuff commented Jan 24, 2018

The header paths weren't broken but we weren't properly including the abseil sources in the podspec.

This is a start on a PR to fix those:
https://github.com/firebase/firebase-ios-sdk/compare/wilhuff/podspec?expand=1

However, we're still stuck on this because it appears that the binary release doesn't include all the private headers required to make this work:

#import <FirebaseCore/FIRLogger.h>

However, if you change your Podfile to also include FirebaseCore from source this works.

  pod 'FirebaseCore', :git => 'https://github.com/firebase/firebase-ios-sdk.git'
  pod 'FirebaseFirestore', :git => 'https://github.com/firebase/firebase-ios-sdk.git', branch: 'wilhuff/podspec'

I'll get the PR in so that you can pull Firestore without the branch and we'll have to look into how to change the release process so that the necessary private headers are included (if that's at all possible).

@wilhuff
Copy link
Contributor

wilhuff commented Jan 25, 2018

Okay, discussing internally, it's clear that the FirebaseCore we publish won't include these headers. If you want to use any components from source you'll need to get FirestoreCore from source too.

Once #704 lands you should be good to go.

@wilhuff
Copy link
Contributor

wilhuff commented Jan 25, 2018

Submitted. The podspec changes are now in master and you should be able to build from source.

@wilhuff wilhuff closed this as completed Jan 25, 2018
@firebase firebase deleted a comment from google-oss-bot Jan 25, 2018
@firebase firebase locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants