Refactor deserialization methods #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not complete just yet; see TODOs for details.
|
NB: It might be easiest to review one commit at at time. |
var-const
approved these changes
Apr 9, 2018
| */ | ||
| uint64_t ReadVarint(); | ||
|
|
||
| // TODO(rsgowman): convert to a pb_istream_t (i.e. not a pointer) |
There was a problem hiding this comment.
Is this comment still relevant? (stream_ is not a pointer)
wilhuff
approved these changes
Apr 10, 2018
| @@ -166,22 +249,38 @@ Writer Writer::Wrap(std::vector<uint8_t>* out_bytes) { | |||
| return Writer(raw_stream); | |||
| } | |||
|
|
|||
| Reader Reader::Wrap(const uint8_t* bytes, size_t length) { | |||
| pb_istream_t raw_stream = pb_istream_from_buffer(bytes, length); | |||
There was a problem hiding this comment.
A few things:
- clang-tidy will complain about "repeating the return type"
- please use brace initialization if possible
Taken together: could this be
return {pb_istream_from_buffer(bytes, length)};
There was a problem hiding this comment.
Done, though as:
return Reader{pb_istream_from_buffer(bytes, length)};
(since ctor is explicit and lint otherwise complains.)
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the refactoring work for the serialization methods.