Skip to content

Make it easier to consume sub-libraries within util #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Apr 10, 2018

This makes it easier to write an async queue library that depends upon the log/assert implementation, without needing to know which it one it is.

This makes it possible for firebase_firestore_util_async_queue_libdispatch to depend upon ${FIREBASE_FIRESTORE_UTIL_LOG}.

Copy link
Contributor

@var-const var-const left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@wilhuff wilhuff merged commit f1fa625 into master Apr 11, 2018
@wilhuff wilhuff deleted the wilhuff/util-cmake branch April 11, 2018 00:51
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants