exposing FIRAppEnvironmentUtil functionalities #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested changes
Apr 11, 2018
There was a problem hiding this comment.
Sorry I didn't check this before, but because of Google open source rules and the copyrights on these files, they need to be in third_party.
I believe you can get the exact same functionality with no source changes and only changing this podspec line - https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseCore.podspec#L29
mylyuic
force-pushed
the
yongmao/move-environment-util-files
branch
from
b5827c3 to
63be6a4
Compare
mylyuic
changed the title
|
@paulb777, updated the PR to only changing podspec to expose that interface |
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
…nt-util-files exposing FIRAppEnvironmentUtil functionalities
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the functionalities defined in that class being exposed.