Remove deprecated token callback #1074
Conversation
Firebase/Messaging/FIRMessaging.m
Outdated
| @@ -572,18 +572,16 @@ - (void)setDelegate:(id<FIRMessagingDelegate>)delegate { | |||
| [self validateDelegateConformsToTokenAvailabilityMethods]; | |||
| } | |||
|
|
|||
| // Check if the delegate conforms to either |didReceiveRegistrationToken:| or | |||
| // |didRefreshRegistrationToken:|, and display a warning to the developer if not. | |||
| // Check if the delegate conforms to either |didReceiveRegistrationToken:|, | |||
There was a problem hiding this comment.
Remove either
Optionally, the comma at the end of the line can be removed too.
| __deprecated_msg("Please use messaging:didReceiveRegistrationToken:, which is called for both \ | ||
| current and refreshed tokens."); | ||
| NS_SWIFT_NAME(messaging(_:didReceiveRegistrationToken:)) | ||
| __IOS_AVAILABLE(10.0); |
There was a problem hiding this comment.
Should this be a lower iOS version? If this method isn't available, then will iOS 9 and lower systems have no way of receiving token updates?
There was a problem hiding this comment.
You are right, this should be universal. For some reason, the protocol is commented to support iOS 10+ but this method somehow doesn't, so I should remove the support commend in protocol to avoid confusion.
| FIRMessagingLoggerWarn(kFIRMessagingMessageCodeTokenDelegateMethodsNotImplemented, | ||
| @"The object %@ does not respond to " | ||
| @"-messaging:didReceiveRegistrationToken:, nor " | ||
| @"-messaging:didRefreshRegistrationToken:. Please implement " | ||
| @"-messaging:didReceiveRegistrationToken:. Please implement " |
There was a problem hiding this comment.
Nit: While we're making this change, we should change to the Swift signature to match (almost) all of our other logs and documentation: messaging(_:didReceiveRegistrationToken:).
There was a problem hiding this comment.
Yeah I will notify the doc team on the change during launch.
I believe all the public doc is using the recommended API (objc & swift), also I've checked all source code the deprecated methods have been removed. Let me know if there's anything you think might be missing.
| __deprecated_msg("Please use messaging:didReceiveRegistrationToken:, which is called for both \ | ||
| current and refreshed tokens."); | ||
| NS_SWIFT_NAME(messaging(_:didReceiveRegistrationToken:)) | ||
| __IOS_AVAILABLE(10.0); |
|
Done. Removed the unnecessary iOS 10 only label |
The deprecated token callback has been replaced by messaging:didReceiveRegistrationToken:.