Options should be nullable for subscription #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Apr 13, 2018
| @@ -146,12 +146,15 @@ - (void)testSubscribeWithInvalidTopic { | |||
| XCTestExpectation *exceptionExpectation = | |||
| [self expectationWithDescription:@"Should throw exception for invalid token"]; | |||
| @try { | |||
| #pragma clang diagnostic push | |||
| #pragma clang diagnostic ignored "-Wnonnull" | |||
There was a problem hiding this comment.
nit: When testing, you can just cast nil pointers to nonnull types. (id _Nonnull)nil
|
Travis failure indicates you need to change the nullability specifier in all declarations of the method: |
|
Oops, right, I should change the header instead of the .m file. |
morganchen12
approved these changes
Apr 13, 2018
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Getting warning message from xcode so we need to define it to remove warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ignore the nonnull warning when intentionally passing a nil parameter.