Skip to content

s/FIRGetSource/FIRFirestoreSource/ #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2018
Merged

s/FIRGetSource/FIRFirestoreSource/ #1087

merged 1 commit into from
Apr 13, 2018

Conversation

rsgowman
Copy link
Member

Incl swift; i.e. s/Source/FirestoreSource/

@rsgowman
s/FIRGetSource/FIRFirestoreSource/
6ab433d 
Incl swift; i.e. s/Source/FirestoreSource/
@rsgowman rsgowman requested a review from wilhuff April 13, 2018 17:33
wilhuff
wilhuff approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsgowman rsgowman merged commit 60407b6 into firestore-api-changes Apr 13, 2018
@rsgowman rsgowman deleted the rsgowman/rename_getsource_to_firestoresource branch April 13, 2018 17:51
rsgowman added a commit that referenced this pull request Apr 13, 2018
@rsgowman
s/FIRGetSource/FIRFirestoreSource/ (#1087)
3ebd8a3 
Incl swift; i.e. s/Source/FirestoreSource/
@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@wilhuff wilhuff

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsgowman @wilhuff @googlebot