Skip to content

import abseil::optional #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

import abseil::optional #1093

wants to merge 1 commit into from

Conversation

zxu123
Copy link
Contributor

@zxu123 zxu123 commented Apr 13, 2018

Based on abseil version bf7fc99, the same version as the other imported abseil libraries.

Will eventually merge to master; right now into the branch abseil-mirror for easy review.

@wilhuff
Copy link
Contributor

wilhuff commented Apr 13, 2018

This should not be merged into abseil-mirror.

You should do something like this

# create a new branch from master
git checkout -b import-optional master

# merge in the updated abseil-mirror branch that contains the pristine sources
git merge abseil-mirror

# apply the changes that make optional buildable
git cherry-pick bcf8dc8ff04ecf5a29d67fc1855b8e0ec8e33600

@wilhuff
Copy link
Contributor

wilhuff commented Apr 16, 2018

I've essentially done this (plus brought in the optional_test.cc and the CMakeLists.txt on the upstream branch) in #1112. Let's continue there.

@wilhuff wilhuff closed this Apr 16, 2018
@zxu123 zxu123 deleted the cpp_optional_changed branch May 25, 2018 13:08
@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants