Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 29, 2025

go/cf3-callable-streaming-clients-ios

Android PR: firebase/firebase-android-sdk#6602


Contribution Workflow
  1. Fork the Firebase repo and clone it.
  2. Add Upstream: git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
  3. Create Branch: git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
    • Where <feature-branch> is the name of the branch (e.g., add-tests-streamable).
  4. Regular workflow: Run style script and git add . && git commit -m "..."
  5. Push: git push origin <feature-branch>
  6. PR: Create a PR on GitHub, with base branch set tofirebase:streamable-functions
  7. Update fork feature branch (if needed):
git fetch upstream
git checkout <feature-branch>
git merge upstream/streamable-functions
git push origin <feature-branch>

eBlender and others added 30 commits December 19, 2024 14:32
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
testing check.sh
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth.

Updating Unit tests.
Add doc for processResponseDataForStreamableContent.
Update func to have a callback.
Update UnitTests
Remove spaces.
Fetch Main branch.
Project clean up.
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
This file is not needed.
This file is not needed.
Add throws
Remove DO - CATCH
@ncooke3
Copy link
Member Author

ncooke3 commented Mar 6, 2025

/gemini please review

Copy link
Contributor

Okay, I will review the pull request now.

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 6, 2025

/gemini Still reviewing?

Copy link
Contributor

It appears I am still reviewing the pull request. I will provide feedback as soon as possible.

@ncooke3 ncooke3 requested a review from paulb777 March 6, 2025 23:56
@ncooke3 ncooke3 added this to the 11.10.0 - M161 milestone Mar 10, 2025
@ncooke3 ncooke3 merged commit baf60ed into main Mar 10, 2025
39 checks passed
@ncooke3 ncooke3 deleted the streamable-functions branch March 10, 2025 18:37
@ncooke3
Copy link
Member Author

ncooke3 commented Mar 10, 2025

This should be in a good state. I'll address any further comments in a follow-up PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants