Skip to content

Add google-app-id to Vertex AI requests #14479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2025
Merged

Add google-app-id to Vertex AI requests #14479

merged 6 commits into from
Feb 25, 2025

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 21, 2025 •
edited
Loading

  • Add google-app-id to Vertex AI requests
  • Add FirebaseInfo struct to package Firebase data used by Vertex AI

Note, the header update part of this PR is disabled in #14493 pending the backend being ready to work with the change.

#no-changelog

rainshen49
rainshen49 reviewed Feb 23, 2025
View reviewed changes
andrewheard
andrewheard reviewed Feb 24, 2025
View reviewed changes
andrewheard
andrewheard approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul! This LGTM to me at least. The FirebaseInfo struct really cleans up a lot of call sites too.

ncooke3
ncooke3 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Andrew's comment. Nice refactor with FirebaseInfo!

@paulb777 paulb777 merged commit 3c7b987 into main Feb 25, 2025
70 checks passed
@paulb777 paulb777 deleted the pb-vertex-app-id branch February 25, 2025 19:54
@paulb777 paulb777 mentioned this pull request Feb 25, 2025
Merged
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@andrewheard andrewheard andrewheard approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

+1 more reviewer

@rainshen49 rainshen49 rainshen49 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paulb777 @ryanwilson @andrewheard @rainshen49 @ncooke3 @google-oss-bot