Skip to content

Refactored FunctionsSerializer.encode(_:) #14524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Refactored FunctionsSerializer.encode(_:) #14524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions FirebaseFunctions/Sources/Internal/FunctionsSerializer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,28 +31,23 @@ extension FunctionsSerializer {
final class FunctionsSerializer {
// MARK: - Internal APIs

func encode(_ object: Any) throws -> AnyObject {
func encode(_ object: Any) throws -> Any {
if object is NSNull {
return object as AnyObject
return object
} else if object is NSNumber {
return try encodeNumber(object as! NSNumber)
} else if object is NSString {
return object as AnyObject
} else if object is NSDictionary {
let dict = object as! NSDictionary
return object
} else if let dict = object as? NSDictionary {
let encoded = NSMutableDictionary()
try dict.forEach { key, value in
encoded[key] = try encode(value)
}
return encoded
} else if object is NSArray {
let array = object as! NSArray
let encoded = NSMutableArray()
try array.forEach { element in
try encoded.add(encode(element))
} else if let array = object as? NSArray {
return try array.map { element in
try encode(element)
}
return encoded

} else {
throw Error.unsupportedType(typeName: typeName(of: object))
}
Expand Down
Loading