Skip to content

Minimize signins in VertexAI integration tests #14697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Minimize signins in VertexAI integration tests #14697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b68c7b
Minimize signins in VertexAI integration tests
paulb777 Apr 9, 2025
167f385
review
paulb777 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,15 @@ struct GenerateContentIntegrationTests {
let userID1: String

init() async throws {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid

if let user = Auth.auth().currentUser {
userID1 = user.uid
} else {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid
}
storage = Storage.storage()
}

Expand Down
14 changes: 9 additions & 5 deletions FirebaseVertexAI/Tests/TestApp/Tests/Integration/ImagenIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@ struct ImagenIntegrationTests {
var userID1: String

init() async throws {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid
if let user = Auth.auth().currentUser {
userID1 = user.uid
} else {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid
}

vertex = VertexAI.vertexAI()
storage = Storage.storage()
Expand Down
14 changes: 9 additions & 5 deletions FirebaseVertexAI/Tests/TestApp/Tests/Integration/IntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,15 @@ final class IntegrationTests: XCTestCase {
var userID1 = ""

override func setUp() async throws {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid
if let user = Auth.auth().currentUser {
userID1 = user.uid
} else {
let authResult = try await Auth.auth().signIn(
withEmail: Credentials.emailAddress1,
password: Credentials.emailPassword1
)
userID1 = authResult.user.uid
}

vertex = VertexAI.vertexAI()
model = vertex.generativeModel(
Expand Down
Loading