[Infra] Fix logic used to find transitive dependencies

[ncooke3]

This should pull in the new GoogleAdsOnDeviceConversion.xcframework in the FirebaseAnalytics/ of the Firebase.zip. Without this PR, GoogleAdsOnDeviceConversion is not found when doing a transitive dependency search because the dictionary used to store the dependency graph is keyed by root specs names instead of subspec names, which the dependency names being indexed are the subspec names. The fix was index with the root spec name instead of the subspec name.

Debug commands:

• For building Analytics:

swift run --package-path ReleaseTooling zip-builder \
  --pods FirebaseAnalytics \
  --platforms ios
  --local-podspec-path /Users/nickcooke/Developer/firebase-ios-sdk \
  --custom-spec-repos https://github.com/firebase/SpecsStaging.git https://github.com/firebase/SpecsDev.git \
  --no-dynamic \
  --keep-build-artifacts \
  --output-dir /Users/nickcooke/Developer/firebase-ios-sdk/zip_output_dir \
  --disable-carthage-version-check \
  --no-include-catalyst \
  --no-update-pod-repo

• For building zip:

swift run --package-path ReleaseTooling zip-builder \
  --keep-build-artifacts \
  --update-pod-repo \
  --no-dynamic \
  --local-podspec-path /Users/nickcooke/Developer/firebase-ios-sdk \
  --output-dir /Users/nickcooke/Developer/firebase-ios-sdk/zip_output_dir/ \
  --disable-carthage-version-check \
  --custom-spec-repos https://github.com/firebase/SpecsStaging.git https://github.com/firebase/SpecsDev.git \
  --platforms ios macos \
  --no-include-catalyst  \
  --no-update-pod-repo

cc: @pcfba

#no-changelog

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

[andrewheard]

LGTM. Thanks for including the commands you used for debugging too. May come in handy for future tasks like this.