Skip to content

[Infra] Remove C99 language standard settings #14970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

[Infra] Remove C99 language standard settings #14970

merged 2 commits into from
Jun 12, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 12, 2025 •
edited
Loading

Fixes #14950

@google-labs-jules
Here's the updated commit message:
464ce0b 
Remove C99 language standard settings

This commit removes the explicit C99 language standard setting (`'GCC_C_LANGUAGE_STANDARD' => 'c99',` and `cLanguageStandard: .c99,`) from all relevant podspec files and the `Package.swift` file.

This change is made to rely on default compiler settings or settings defined elsewhere, promoting consistency and reducing redundancy.
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an overall Firebase release note

@ncooke3 ncooke3 merged commit 5902b40 into main Jun 12, 2025
5 checks passed
@ncooke3 ncooke3 deleted the remove-c99-standard branch June 12, 2025 20:13
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 12, 2025 •
edited
Loading

Add an overall Firebase release note

Thanks, @paulb777. Done!

@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
@ncooke3 @google-labs-jules @cherylEnkidu
[Infra] Remove C99 language standard settings (#14970)
782689c 
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: abtesting api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: installations api: messaging api: performance api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails with “C99 was enabled in PCH file” when using Firebase 11.15.0 with Xcode 26 beta
3 participants
@ncooke3 @google-oss-bot @paulb777