Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 18, 2025

Previously, Firebase Dynamic Links was used in the InAppMessaging-Example-iOS and fiam-external-ios-testing-app sample applications for handling deep links.

With this change, all usage of Firebase Dynamic Links has been removed from these sample apps:

  • I removed the FirebaseDynamicLinks import and related code from InAppMessaging-Example-iOS/AppDelegate.m.
  • I removed the FirebaseDynamicLinks pod dependency from InAppMessaging-Example-iOS's Podfile.
  • I removed FIRDynamicLinks usage from fiam-external-ios-testing-app/AppDelegate.m.
  • I removed the Firebase/DynamicLinks pod dependency from fiam-external-ios-testing-app's Podfile.

The sample apps no longer rely on Firebase Dynamic Links for their functionality.

…plications.

Previously, Firebase Dynamic Links was used in the `InAppMessaging-Example-iOS` and `fiam-external-ios-testing-app` sample applications for handling deep links.

With this change, all usage of Firebase Dynamic Links has been removed from these sample apps:
- I removed the `FirebaseDynamicLinks` import and related code from `InAppMessaging-Example-iOS/AppDelegate.m`.
- I removed the `FirebaseDynamicLinks` pod dependency from `InAppMessaging-Example-iOS`'s Podfile.
- I removed `FIRDynamicLinks` usage from `fiam-external-ios-testing-app/AppDelegate.m`.
- I removed the `Firebase/DynamicLinks` pod dependency from `fiam-external-ios-testing-app`'s Podfile.

The sample apps no longer rely on Firebase Dynamic Links for their functionality.
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Jun 18, 2025
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@ncooke3 ncooke3 merged commit 60d57b4 into main Jun 18, 2025
48 checks passed
@ncooke3 ncooke3 deleted the remove-dynamic-links-from-fiam-samples branch June 18, 2025 02:43
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
…applications. (#15000)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants